-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip impeller goldens on release #51240
Skip impeller goldens on release #51240
Conversation
ci/builders/mac_host_engine.json
Outdated
"--variant", | ||
"host_release", | ||
"--type", | ||
"impeller-golden" | ||
], | ||
"run_if": "main" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be test_if
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
My understanding is that the root cause of these tests failing on the release builder is that the role account on the release builders isn't in the ACL to upload to the bucket for SkiaGold. Instead of doing this, can the role account be added to the ACL for the bucket? |
Moving discussion to email |
…144784) flutter/engine@1282895...9e8ccaa 2024-03-07 jesus_sguerrero@hotmail.com Skip impeller goldens on release (flutter/engine#51240) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This reverts commit 9e8ccaa.
No description provided.